Generate: validate model_kwargs on FLAX (and catch typos in generate arguments)#18653
Merged
gante merged 1 commit intohuggingface:mainfrom Aug 18, 2022
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FLAX version of #18261
Adds model_kwargs validation to FLAX generate, which also catches typos in the arguments. See the PR above for more details and an example of the error message users will see.